search

RxSwiftCommunity / RxKeyboard

Reactive Keyboard in iOS
MIT License
1.6k stars 175 forks source link

Update RxSwift dependency #90

Closed devxoul closed 5 years ago

devxoul commented 5 years ago

Background

freak4pc commented 5 years ago

@devxoul CI is failing

devxoul commented 5 years ago

@freak4pc Yeah, it's because RxSwift 4.5.0 doesn't have platforms parameter in the Package description. I've just sent a patch for this issue (https://github.com/ReactiveX/RxSwift/pull/1913).

freak4pc commented 5 years ago

This has to be based on RxSwift 5.0 (it's the only version to support both Swift 4.2 and Swift 5). @devxoul

rynecheow commented 5 years ago

@devxoul @freak4pc I updated the PR to point to RxSwift 5.0, do you think this would do for a releasable version?

rynecheow commented 5 years ago

Changes resolved! @freak4pc

freak4pc commented 5 years ago

Looks good, let's wait for CI first

rynecheow commented 5 years ago

All green

freak4pc commented 5 years ago

Looks good! @devxoul, I would appreciate giving you another day or two to review so leaving this open until Friday in case you have anything pressing to change :)

On friday I hope to merge this and push 1.0.0 out. Thanks @rynecheow !

rynecheow commented 5 years ago

Hey @devxoul @freak4pc - Is this ready?