Do not compile because of `Use of undeclared type 'Image'`

RxSwiftCommunity / RxKingfisher

Reactive extension for the Kingfisher image downloading and caching library

MIT License

223 stars 39 forks source link

Do not compile because of `Use of undeclared type 'Image'` #17

Closed gorbat-o closed 5 years ago

gorbat-o commented 5 years ago

Hi,

This library does not compile since a Kingfisher update I believe. I replaced the ImageView type with KFCrossPlatformImageView and Image type with KFCrossPlatformImage

Will it be updated? I can create a PR for that if needed. (I am testing right now)

freak4pc commented 5 years ago

Hey @gorbat-o. See this issue I opened: https://github.com/onevcat/Kingfisher/issues/1303

It seems the maintainer of Kingfisher broke semantic versioning by changing symbol names without bumping a major version, thus breaking this framework. I'll try to take care of this a bit later, I just want to make sure it was only a simple rename and nothing else.

Thanks for reporting this!

freak4pc commented 5 years ago

He cut a new minor version, this should be fixed.

gorbat-o commented 4 years ago

Awesome, thank you for your quick reply!!