search

RxSwiftCommunity / RxKingfisher

Reactive extension for the Kingfisher image downloading and caching library
MIT License
223 stars 39 forks source link

Swift 4.2 support #5

Closed dinsen closed 6 years ago

dinsen commented 6 years ago

Hey @freak4pc I've committed the changes for CI.

I have not worked with Circle CI before, so please check all made correct.

freak4pc commented 6 years ago

@Dinsen Seems like CI is failing - could you confirm the commands build locally on your Mac?

dinsen commented 6 years ago

@freak4pc they also failed locally.

I have changed the config back to run build instead of test and rebased. There is currently no tests so is it enough just to run build?

freak4pc commented 6 years ago

Looks good, thanks!

rxswiftcommunity[bot] commented 6 years ago

Thanks a lot for contributing @Dinsen! I've invited you to join the RxSwiftCommunity GitHub organization – no pressure to accept! If you'd like more information on what this means, check out our contributor guidelines and feel free to reach out with any questions.

Generated by :no_entry_sign: dangerJS