search

RxSwiftCommunity / RxRealm

RxSwift extension for RealmSwift's types
MIT License
1.15k stars 263 forks source link

Swift 5 and Xcode 10.2 support #123

Closed rynecheow closed 5 years ago

rynecheow commented 5 years ago

Supporting Swift 5 and Xcode 10.2 officially

freak4pc commented 5 years ago

Hey - RxSwift 5 is coming in a bit, let’s wait for that before putting this PR together

lukas1 commented 5 years ago

RxSwift 5 has been released :-)

rynecheow commented 5 years ago

Ready for review @icanzilb @freak4pc :)

rynecheow commented 5 years ago

Ready for another review @freak4pc

rynecheow commented 5 years ago

Sure @freak4pc :)

rynecheow commented 5 years ago

Are we ready to merge this?

icanzilb commented 5 years ago

I’m on vacation and the PR seems too big to review on my phone. As long as the test suite passes and the example apps (both iOS and macOS) behave as before I’m good with merging

rynecheow commented 5 years ago

Thanks @icanzilb! @freak4pc Would need your help to merge the PR as I can't be merging my own if all's good!

freak4pc commented 5 years ago

@rynecheow At home right now, I'll run it locally at night and let you know. Thanks :)