RxSwiftCommunity / RxRealm

RxSwift extension for RealmSwift's types
MIT License
1.15k stars 263 forks source link

Update for Xcode 14 build #187

Closed marcuswu0814 closed 2 years ago

marcuswu0814 commented 2 years ago

According to this PR, the Realm version should update to support build with Xcode 14. πŸ™

marcuswu0814 commented 2 years ago

Hi @JoeMatt, could you please help to review and merge this PR? πŸ˜€

JoeMatt commented 2 years ago

This isn't a blocker since you can just "package update" and should pull the latest version of RxSwift to fix this issue. Tested myself on a few projects and everything should work as-is with XCode 14 after a dependency update.

That being said, I'll approve this PR but not in a rush to make a release based on it since fundamietally it doesn't change the version locking restrictions since the latest RxRealm is a minor version, not a major.

marcuswu0814 commented 2 years ago

Hi @JoeMatt, really thanks for your tip! ❀️ Finally I run pod update Realm RealmSwift RxRealm and the Realm version can be updated successfully. πŸŽ‰ BTW, I faced problem by running pod update RealmSwift and it cause dependency problem previously. πŸ˜…

JoeMatt commented 2 years ago

Yeah previously it may have but since upstream updates requires weren’t version locked in our pod file or package.swift, they should both work now on master with RxSwift package update.

Joe Mattiello


From: Marcus Wu @.> Sent: Wednesday, June 15, 2022 6:24:21 AM To: RxSwiftCommunity/RxRealm @.> Cc: Joseph Mattiello @.>; Mention @.> Subject: Re: [RxSwiftCommunity/RxRealm] Update for Xcode 14 build (PR #187)

Hi @JoeMatthttps://github.com/JoeMatt, really thanks for your tip! ❀️ Finally I run pod update Realm RealmSwift RxRealm and the Realm version can be updated successfully. πŸŽ‰ BTW, I faced problem by running pod update RealmSwift and it cause dependency problem previously. πŸ˜…

β€” Reply to this email directly, view it on GitHubhttps://github.com/RxSwiftCommunity/RxRealm/pull/187#issuecomment-1156290111, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AADBT6DJ6BH6L5FYGDBJIQLVPGVNLANCNFSM5YWJ42PQ. You are receiving this because you were mentioned.Message ID: @.***>