arshiacont commented 9 months ago

changed several Observable types to RxSwift.Observable to overcome XCode 15 conflict

trivial

fixes #199 and #201

rxswiftcommunity[bot] commented 9 months ago

Thanks a lot for contributing @arshiacont! I've invited you to join the RxSwiftCommunity GitHub organization – no pressure to accept! If you'd like more information on what this means, check out our contributor guidelines and feel free to reach out with any questions.

Generated by :no_entry_sign: dangerJS

arshiacont commented 9 months ago

@JoeMatt this PR is a no brainer and solves the XCode 15 issue... .

erikmartens commented 9 months ago

Any update on the progress or remaining requirements for this to be merged?

arshiacont commented 9 months ago

Any update on the progress or remaining requirements for this to be merged?

A maintainer for the repo is needed here.. @JoeMatt @freak4pc ?

asn111 commented 9 months ago

I am also unable to load my project and these are the issues it displays. Any idea how to fix these? Thanks 🙏

arshiacont commented 9 months ago

@JoeMatt Possible to release a hotfix 5.0.6? (thanks for approval)

JoeMatt commented 9 months ago

Tonight. Finally have a break on the rain around here.

yspreen commented 9 months ago

wanna add the iOS 12 minimum version bump too?

hoc081098 commented 9 months ago

Please publish it 💯

erikmartens commented 9 months ago

Until either @JoeMatt or @freak4pc merge this and update the PodSpec all of y'all (@asn111 ?) who are using CocoaPods and have updated to macOS Sonoma, which prevents you from using Xcode 14, can just point to the branch of this fix in the Podfile by using pod 'RxRealm', :git => 'https://github.com/arshiacont/RxRealm.git', :branch => 'bugfix/xcode15', :commit => 'ec4ac63'

I'm able to build and run my app fine on macOS 14 with Xcode 15.

imvityalee commented 9 months ago

Can you merge this ? @JoeMatt

rynecheow commented 9 months ago

@arshiacont Able to fix the pipeline before we merge this?

arshiacont commented 9 months ago

@arshiacont Able to fix the pipeline before we merge this?

@rynecheow the pipeline errors seems to be a dependency issue and independent of any PR... .

@JoeMatt you kindly approved the changes last week amid rain! :) If you could merge to the main branch it'll avoid people to point to my Fork (which is probably not right!). Getting an SPM/Pod release would be best.

diegothucao commented 9 months ago

Hi team, could you check to release this ?

s14228so commented 9 months ago

@JoeMatt Please publish it🙇🙏

Tom0430 commented 9 months ago

@JoeMatt Possible to release?

ibukiblue commented 9 months ago

@JoeMatt Is there some problem that makes it impossible to release?🫠

freak4pc commented 9 months ago

Stop commenting and tagging every 15 minutes, this is seriously disrespectful. This project isn't maintained as was noted before and people are volunteering their free time to try and assist. If you're under a time crunch just direct your project to the specific tag / commit and move on until this is resolved.

arshiacont commented 9 months ago

Just updated Cocoapod dependency in the workflow hoping this will pass the checks and we can have a smooth release. Pending workflow approval and final check, we might want to modify other dependencies... .

yspreen commented 9 months ago

Is the iOS 11.0 vs 12.0 dependency issue fixed as well? That's causing some build issues for us. We had to bump the minimum manually

arshiacont commented 9 months ago

Is the iOS 11.0 vs 12.0 dependency issue fixed as well? That's causing some build issues for us. We had to bump the minimum manually

@yspreen I would create a separate issue on that. Focusing on getting this one over with.

freak4pc commented 9 months ago

the tl;dr here is that - if someone wants to take over and maintain this project, we're happy to add a second owner to take care of it. If not, it might take a bit of time due to time (and war) constraints.

imvityalee commented 8 months ago

the tl;dr here is that - if someone wants to take over and maintain this project, we're happy to add a second owner to take care of it. If not, it might take a bit of time due to time (and war) constraints.

It would be great if you will add someone as an owner, I can help with this stuff. You can add me

rynecheow commented 8 months ago

I can help to approve this and merge, provided the pipeline is green :) Able to help fixing the pipeline error please? Seems like a Cocoapods iOS demo issue

arshiacont commented 8 months ago

I can help to approve this and merge, provided the pipeline is green :) Able to help fixing the pipeline error please? Seems like a Cocoapods iOS demo issue

Just a hint: There is apparently a problem with the version of the dependency activesupport used here... I had this on my local machine which was solved by just fixing the version to what was required by Cocoapods... but I did not dig into how we can solve it on this project.

lihao6485 commented 8 months ago

@arshiacont yes you are right, it is related to the latest version of activesupport (7.1.0) https://github.com/CocoaPods/CocoaPods/issues/12081

as a temporary workaround could we try to add gem 'activesupport', '>= 6.1.7.3', '< 7.1.0' into gemfile in this PR?

arshiacont commented 8 months ago

@lihao6485 @rynecheow just moved Cocoapod dependency to 1.14.0 (released yesterday) that addresses the ActiveSupport crash. Hopefully this will fix the workflow for this PR.

lihao6485 commented 8 months ago

@arshiacont I have fixed the CI build issue, could you try to merge this PR in your branch and run the CI again? https://github.com/arshiacont/RxRealm/pull/1

arshiacont commented 8 months ago

@arshiacont I have fixed the CI build issue, could you try to merge this PR in your branch and run the CI again?

https://github.com/arshiacont/RxRealm/pull/1

Done! Awaiting approval

fpedro23 commented 8 months ago

Thanks for merging!

RxSwiftCommunity / RxRealm

Fix Observable namespace for Swift5.9/XCode15 conflict #202

trivial