search

RxSwiftCommunity / RxRealm

RxSwift extension for RealmSwift's types
MIT License
1.15k stars 265 forks source link

Upgrading to Swift 4 and Xcode 9 #87

Closed bsrz closed 7 years ago

bsrz commented 7 years ago
icanzilb commented 7 years ago

is that different than the current swift4 branch?

bsrz commented 7 years ago

@icanzilb it's different in the sense that it doesn't require beta versions of dependencies. Do you know what is the ETA for releasing RxSwift 4 and Realm 3?

icanzilb commented 7 years ago

It looks like the current betas of both RxSwift and RealmSwift will be the last ones before a release, but I do not know that for sure.

icanzilb commented 7 years ago

ok, I see - this PR looks to be dealing mostly with Carthage stuff, I think we can safely merge it to master

bsrz commented 7 years ago

@icanzilb yes, it fixes https://github.com/RxSwiftCommunity/RxRealm/issues/86 and there were no code changes from Swift 3 to Swift 4. I was going to try setting SWIFT_VERSION to 3 to validate that all works. Let me know what you want to do.

bsrz commented 7 years ago

@icanzilb I have confirmed all is working with Xcode 9 and Swift 3, feel free to merge this in and we'll wait for the swift4 branch on our side.

bsrz commented 7 years ago

@icanzilb do you still intend on merging this and tag as 0.7.2? Just trying to point to this repo instead of my fork.

icanzilb commented 7 years ago

@bsarrazin yeah, will merge this today