Updated RxStarscream to Swift 4 and RxSwift 4. (Sample App included)

RxSwiftCommunity / RxStarscream

A lightweight extension to subscribe Starscream websocket events with RxSwift

MIT License

152 stars 52 forks source link

Updated RxStarscream to Swift 4 and RxSwift 4. (Sample App included) #17

Closed pedrommcarrasco closed 6 years ago

pedrommcarrasco commented 6 years ago

@freak4pc check it out

freak4pc commented 6 years ago

Uhm very interesting. I'll poke at this tomorrow.

pedrommcarrasco commented 6 years ago

@freak4pc What's happening? Still having problems with CircleCI?

freak4pc commented 6 years ago

@pedrommcarrasco It's not triggering. I think it's because your branch wasn't cut from the current master, but from a previous version (before Circle was done). I'll see if there's a way to sort this out tomorrow.

pedrommcarrasco commented 6 years ago

@freak4pc In case there isn't a easy way, I have no problems with creating a whole new fork. Anyways, keep me updated in case if there's anything I can do.

freak4pc commented 6 years ago

@pedrommcarrasco Ok, got it. Let's see if we get a green light here. I'll still want to review the code itself tomorrow but want to make sure tests pass :)

pedrommcarrasco commented 6 years ago

@freak4pc Praying :D

pedrommcarrasco commented 6 years ago

@freak4pc Now that I notice, README also needs to be updated to the current RxSwift syntax. In case you want me to do it, just tell me. And CircleCI just got us some good news!

freak4pc commented 6 years ago

@pedrommcarrasco Yeah that would be highly appreciated :)

I'll give the code a quick look tomorrow and will probably merge and cut a new build !!

If you could also add to the readme the fact that:

RxSwift 3.x is 0.7
RxSwift 4.x is 0.8

You can do a table similar to this (RxSwift vs RxStarscream versions)

https://github.com/Moya/Moya#moya-version-vs-swift-version

pedrommcarrasco commented 6 years ago

@freak4pc Will try to do it tonight, will keep you updated.

pedrommcarrasco commented 6 years ago

@freak4pc I think everything is done and ready!

freak4pc commented 6 years ago

Hey @pedrommcarrasco, thanks for your help here :)

I made a few fixes for warnings in the project itself
I squashed and cleaned up some of your commits into 1 commit (you had about 7 commits changing the README)

Gonna merge this now and push a version later.

Thanks !

pedrommcarrasco commented 6 years ago

You welcome @freak4pc! Feel fere to ask me if you need help in anything! Best regards!