search

RxSwiftCommunity / RxStarscream

A lightweight extension to subscribe Starscream websocket events with RxSwift
MIT License
152 stars 52 forks source link

Fixed not working pong delegate, added send pong button, fixed format… #6

Closed CezaryKopacz closed 7 years ago

CezaryKopacz commented 7 years ago

…ting

CezaryKopacz commented 7 years ago

Can anyone from @RxSwiftCommunity/contributors check this?

CezaryKopacz commented 7 years ago

@RxSwiftCommunity/contributors Anyone :) ?

CezaryKopacz commented 7 years ago

@freak4pc Pushed updated commit with your suggestions - could you please check again?

CezaryKopacz commented 7 years ago

@freak4pc thanks again for your time. Please check my comments above and I'll update this PR later on with minor changes.

freak4pc commented 7 years ago

Yup, let's make the minor fixes and merge this I think.

CezaryKopacz commented 7 years ago

Just pushed minor changes.

freak4pc commented 7 years ago

Looks good to me, Let's do it :)