RxSwiftCommunity / RxSwiftExt

A collection of Rx operators & tools not found in the core RxSwift distribution

MIT License

1.33k stars 213 forks source link

add swift package manager support. #192

Closed imkerberos closed 5 years ago

imkerberos commented 5 years ago

trivial

Add "Package.swift" to supporting Swift Package Manager.

rxswiftcommunity[bot] commented 5 years ago

It looks like code was changed without adding anything to the Changelog.

Generated by :no_entry_sign: dangerJS

vzsg commented 5 years ago

An example config could look as simple as this:

version: 2
jobs:
  "RxSwiftExt SPM":
    macos:
      xcode: '9.4.0'
    steps:
      - checkout
      - run: swift build
      - run: swift test

vzsg commented 5 years ago

On a second thought, it might be better to extend the RxSwiftExt Test job with one more named run section, instead of introducing a separate job. It took me too long to realize how the script works.

Try adding this after the "Test tvOS" step:

      - run:
          name: Test Swift Package Manager
          command: set -o pipefail && swift build && swift test

And sorry for sidetracking you.

freak4pc commented 5 years ago

Resolved in #230