search

RxSwiftCommunity / RxSwiftExt

A collection of Rx operators & tools not found in the core RxSwift distribution
MIT License
1.33k stars 213 forks source link

Latest release not compatible with RxSwift 5.0+ #206

Closed ValCanBuild closed 5 years ago

ValCanBuild commented 5 years ago

I've tried upgrading my RxSwift carthage dependency to 5.0.1 but when I do so, RxSwiftExt fails to build. Looking at the build log, there is a lot of warnings about deprecation but only two compile errors:

RxSwiftExt/Source/RxSwift/toSortedArray.swift:20:26: error: cannot convert return expression of type 'PrimitiveSequence<SingleTrait, [Self.Element]>' to return type 'Observable<[Self.Element]>'
        return toArray().map { $0.sorted(by: by) }
RxSwiftExt/Source/RxCocoa/unwrap+SharedSequence.swift:19:47: error: use of undeclared type 'S'
    public func unwrap<T>() -> SharedSequence<S, T> where E == T? {
freak4pc commented 5 years ago

Please follow #205. RxSwift 5 was released two days ago, some patience :)

ValCanBuild commented 5 years ago

Apologies, @freak4pc , didn't see there was a pending PR. Shall I close this?

freak4pc commented 5 years ago

Sounds good for now. Thanks !