search

RxSwiftCommunity / RxSwiftExt

A collection of Rx operators & tools not found in the core RxSwift distribution
MIT License
1.33k stars 213 forks source link

`once`: Use NSRecursiveLock instead of deprecated OSAtomicOr32OrigBarrier #209

Closed M0rtyMerr closed 5 years ago

M0rtyMerr commented 5 years ago

Resolve https://github.com/RxSwiftCommunity/RxSwiftExt/issues/200

@freak4pc mentioned that adding RxAtomic as dependency is an unwanted solution, so here is yet another AtomicInt implementation with few needed operators. Tests were just copied from RxSwift repo

freak4pc commented 5 years ago

Not sure I'd want to copy AtomicInt in its entirety just for this. Do you think once could be refactored with a regular NSRecursiveLock ?

rxswiftcommunity[bot] commented 5 years ago
Fails
:no_entry_sign: Could not find Dangerfile at org/all-prs.ts on RxSwiftCommunity/peril on branch master ## Full state of PR run: ```json { "branch": null, "dangerfileBranchForPR": "feature/atomic", "neededDangerfileIsLocalRepo": false, "repoForDangerfile": "RxSwiftCommunity/peril", "run": { "action": "edited", "dslType": 0, "event": "pull_request", "branch": "master", "dangerfilePath": "org/all-prs.ts", "repoSlug": "RxSwiftCommunity/peril", "feedback": 0 }, "settings": { "commentableID": 209, "eventID": "Unknown", "hasRelatedCommentable": true, "installationID": 77085, "installationSettings": { "env_vars": [], "ignored_repos": [], "modules": [] }, "isRepoEvent": true, "isTriggeredByUser": true, "repoName": "RxSwiftCommunity/RxSwiftExt", "repoSpecificRules": {}, "triggeredByUsername": "freak4pc" } } ```

Generated by :no_entry_sign: dangerJS