Open ajjnix opened 5 years ago
You can't technically do anything against the contract.
The stream isn't terminated because ignoreErrors
is just an alias to retry
- by infinitely retrying the error'd stream, you are stuck in an infinite loop.
What we can do is change the documentation perhaps. I also think the naming is a bit misleading, because you're not exactly ignoring errors. Ignoring errors would be something like materialize
, filtering errors and dematerialize
.
@fpillet your thoughts?
PublishSubject
is not working withignoreErrors
function becauseignoreErrors
is synonym ofretry
. ButPublishSubject
can'tretry
by contract cause it's not operation.In this code I can think the sequence can't terminated on error (and yes it's not terminated 😺) but it's not right by contract of
Observable
. So I think this operator is mislead and I suggest to remove it.