search

RxSwiftCommunity / RxSwiftExt

A collection of Rx operators & tools not found in the core RxSwift distribution
MIT License
1.33k stars 213 forks source link

Fix filterMap doc #trivial #231

Closed M0rtyMerr closed 5 years ago

M0rtyMerr commented 5 years ago

https://github.com/RxSwiftCommunity/RxSwiftExt/issues/224

freak4pc commented 5 years ago

As long as we're here, want to change the underlying impl. to use compactMap ? As long as we're not breaking the public API I'm OK with it.

M0rtyMerr commented 5 years ago

@freak4pc what do you think about creating a separate DEPRECATED section in docs for deprecated methods? Or annotation in code is enough?

freak4pc commented 5 years ago

We won't use deprecation annotations right now anyways - we'll leave the method as is and just use compactMap below the hood IMO (makes more sense for now). When we switch a major version we can deprecate.

M0rtyMerr commented 5 years ago

Yeah, I understand your suggestion, please review changes. I just asked about future plans (unwrap & filterMap deprecation)

rxswiftcommunity[bot] commented 5 years ago

It looks like code was changed without adding anything to the Changelog.

Generated by :no_entry_sign: dangerJS