Closed akolov closed 4 years ago
Hey, this definitely doesn't seem like an issue with the framework as these two methods have entirely different signatures.
@jdisho could you take a look at his example perhaps?
Thanks for pointing it out. I will have a look asap 😊
Hey @jdisho - can you let me know if you'll be able to take a look in the next day or two? No problem if not, but I want to know since otherwise I'll just carve out some time to look into it :)
Sorry for the late reply and not finding the time this weekend. Definitely, I will have a look tomorrow @freak4pc 😊
Sent with GitHawk
I see the problem... 🤔
We can either rename to mergeWith(_ others:)
or, convert the others
to an array rather than having it as a sequence.
Any other suggestion?
the former isn't great because we already have zip(with:) Would converting to an array work here ? Seems reasonable to me.
+1 to the idea of using an array. 😇
Cool, @cliss - any way for you to confirm that changing the method to use an array would solve the ambiguity for your code base ? I'll try taking a look myself tomorrow or so and push a PR.
Point me to a branch and I'm happy to give it a shot!
Hey @cliss - it's on the mergeWithArray
branch :)
Thank you!
It definitely solves issues I was having with merge.
@cliss - would appreciate you letting me know as well before I'm cutting a new release :) thanks @akolov !
Crap, I'm so sorry; just saw this. Will test first thing tomorrow morning.
My utmost apologies!
@freak4pc Concur with @akolov; the mergeWithArray
branch fixed my build. 🎉
Apologies, again, for the delay!
Merged it, will be out in a new release by next week most likely :)
@freak4pc bump 😇
Oh yikes! Thought I took care of this since I merged it 🤦♂ I just put a reminder to cut a release tomorrow. Thanks for the reminder! @cliss
@cliss and others - 5.2.0 was just released 🎉
Thanks @freak4pc! 🍻
Hi, I've stumbled upon an issue where importing RxSwiftExt breaks behavior of
Observable.of(...).merge()
.Given the following sample code:
Now, depending on whether I
import RxSwiftExt
or not produces drastically different result.First, output without RxSwiftExt, everything works as expected:
Next, if I
import RxSwiftExt
, result is something completely unexpected. I get event completed and whole thing disposed at the end:In fact, if I step into
merge()
when RxSwiftExt is imported, it actually goes insidemerge(with:)
method.I can reliably reproduce this with RxSwift 5.0.1 and RxSwiftExt 5.1.1, both built with Carthage using Xcode 10 (10G8) and Xcode 11 GM 2 (11A491c).
Is this expected behavior or am I doing something wrong here?
I'm attaching a sample project I used to pinpoint the issue, please run
carthage bootstrap
to install RxSwift and RxSwiftExt.merge-issue.zip