search

RxSwiftCommunity / RxSwiftExt

A collection of Rx operators & tools not found in the core RxSwift distribution
MIT License
1.33k stars 213 forks source link

Link to RxCocoa on macOS & tvOS targets #248

Closed lucolivier-dumaisblais closed 4 years ago

lucolivier-dumaisblais commented 4 years ago

Hello RxSwiftExt maintainers!

The main app I work on uses RxSwiftExt and does not use any package managers to integrate it. RxSwiftExt is integrated in a codebase containing both macOS and iOS code. We ran into an issue where our Mac target would no longer compiled saying RxCocoa was missing when compiling RxSwiftExt. This issue was non-existant when using RxSwiftExt with our iOS target.

While looking at the Package.swift & the RxSwiftExt.podspec files, the dependency to RxSwift is set correctly. When you integrate the Xcode Project to compile RxSwiftExt yourself, only the iOS target was linking correctly to its dependencies.

Moreover, I removed linking to RxRelay since no target was using it.

rxswiftcommunity[bot] commented 4 years ago

Thanks a lot for contributing @Lucconouche! I've invited you to join the RxSwiftCommunity GitHub organization – no pressure to accept! If you'd like more information on what this means, check out our contributor guidelines and feel free to reach out with any questions.

Generated by :no_entry_sign: dangerJS

lucolivier-dumaisblais commented 4 years ago

Thanks @freak4pc!