search

RxSwiftCommunity / RxSwiftExt

A collection of Rx operators & tools not found in the core RxSwift distribution
MIT License
1.32k stars 213 forks source link

Added Observable+Alias.swift to project file with correct targets. #trivial #275

Closed adamsousa closed 11 months ago

adamsousa commented 1 year ago

Observable-Alias.swift was missing targets and references in the project file. Added in this PR

trivial

rxswiftcommunity[bot] commented 1 year ago

Thanks a lot for contributing @adamsousa! I've invited you to join the RxSwiftCommunity GitHub organization – no pressure to accept! If you'd like more information on what this means, check out our contributor guidelines and feel free to reach out with any questions.

Generated by :no_entry_sign: dangerJS

fpedro23 commented 1 year ago

Thanks for fixing, when do you plan to merge and release this?

freak4pc commented 1 year ago

Thanks for the fix, but I'm not sure adding it to the project is relevant at all to fetching it via SPM or even CocoaPods. It's only for the Sample Project itself, unless you're referring to Carthage?

adamsousa commented 1 year ago

We are using Carthage, I wasn't able to rebuild this framework until this file was added to the project file.

marcbaldwin commented 11 months ago

I was also unable to build this framework using Carthage. Thanks for the fix, now that Xcode15 has been released, it'd be great to get this released too 🙏

freak4pc commented 11 months ago

Thanks!