search

RxSwiftCommunity / RxTheme

Theme management based on Rx
MIT License
382 stars 29 forks source link

Some ideas for new version #3

Closed tosbaha closed 6 years ago

tosbaha commented 6 years ago

Hi, Yesterday, I worked on this project and tried to add couple of features. Since Swift 4, enums have allCases property and I think theme can be good case for this. Since I use enum, type safety is guaranteed. Basically I added the following;

  1. Converted theme array to single enum.
  2. Theme can be set directly or with its raw value.
  3. All Themes and theme names
  4. Random theme
  5. Removed deprecated statusBarStyle binding.
wddwycc commented 6 years ago

@tomahh

Thanks for your contribution.

I do agree that CaseIterable can improve the interface.

I opened a new branch swift4.2, could you rebase your PR to that branch, which would be merged after Xcode10 released officially.

And by the way, could you separate your currenct PR to multiple PRs, where each serves a single purpose.