search

RxSwiftCommunity / contributors

Guidelines for contributing to the RxSwiftCommunity, and a good place to raise questions.
MIT License
21 stars 3 forks source link

RxBluetooth #9

Open bontoJR opened 8 years ago

bontoJR commented 8 years ago

I started RxBluetooth with the goal of creating a cool wrapper, unfortunately I have no time left since I started this project, but @mane87 is doing a great job in maintaining it and will definitely start to implement a better version. So I think the time to move it under the RxSwiftCommunity has arrived!

Any thoughts?

ashfurrow commented 8 years ago

Sounds cool! Do you have a link to the project?

mane87 commented 8 years ago

https://github.com/SideEffects-xyz/RxBluetooth

ashfurrow commented 8 years ago

Looks awesome! My only suggestions would be to add some examples, installation instructions, and some mention of RxSwift to the readme. I don't see any tests, but :grimacing: that sounds really hard to test, so ¯_(ツ)_/¯

mane87 commented 8 years ago

I will definately improve the readme :thumbsup: I just discussed with @bontoJR how we could test this stuff. Any suggestions from your side @ashfurrow ?

ashfurrow commented 8 years ago

I haven't touched Core Bluetooth in years, very hard to do. It's a fairly thin abstraction on top of the hardware, could be worth asking others for advice.

mane87 commented 8 years ago

Do you anyone who could point us in the right direction?

ashfurrow commented 8 years ago

No, but I have a twitter I can ask.

orta commented 8 years ago

You might have to end up using a mocking library pretty extensively, at a guess.

bontoJR commented 8 years ago

@orta is right, there's no way to test this library with a real CB instance, we need to mock all the objects and simulate every single case (pairing, restore, failure at any level, etc...). It's a non-trivial task, CB is still a not really friendly framework, especially for the fact that has some mandatory delegates that are used to restore the connection once the app has been opened.

I can definitely take some time to help @mane87 on this.

ashfurrow commented 7 years ago

Hey there – any follow-up on this? Happy to provide high-level direction. Cheers!

bobgodwinx commented 7 years ago

@bontoJR @ashfurrow Let me know if I can help you in this area. I worked extensively with bluetooth in my last company.