RxTUDelft / RxJavaGames

10 games in RxJava + JavaFx
16 stars 5 forks source link

Crazy eights #7

Closed Lars6 closed 10 years ago

Lars6 commented 10 years ago

I have finished the first version of the crazy eights game. If there is enough time, we could extend it or add animations later. Let me know if you'd like something to be changed!

rvanheest commented 10 years ago

First of all, the game looks absolutely glorious! Good job. Some questions and suggestions:

  1. Maybe you can add warning messages when the player wants to play a card that is not allowed.
  2. Maybe you can add symbols to the Suit Selector when the player plays an 8.
  3. When a suit is selected by the computer, an info pops up with the given suit. Maybe you should put that suit in the info label (with scores) until the next move, so that the player can also see what kind of card he has to play.
  4. When playing an 8 and clicking Cancel, the game continues. I would think that then the play of that card would be reverted.
  5. Is there an end to the card stack? I just played a really long game and the the stack never became empty.
  6. Maybe given the amount of cards of the computer player, this is not correctly displayed? image

Keep up the good work!

Lars6 commented 10 years ago

@rvanheest, thanks for your suggestions. As you have already seen, I added most of them.

  1. There is now a warning when the player plays an invalid card.
  2. The suit selector contains the utf-8 icons for the different suits.
  3. When the computer plays an 8, there is a message with the chosen suit which disappears after the next valid play.
  4. The cancel button should not be here, but the functionality to remove this button doesn't work for this kind of dialogs. I could create a custom dialog, but that will take too much time for now.
  5. If the stack is empty, the cards from the discard pile (except the card at the top) are shuffled and added to the stock pile again. If this is not possible because there are no cards in the discard pile, a new deck of cards will be added.
  6. This should be fixed now :-)