Closed mijon closed 1 year ago
Hey, it looks like you were looking at the code at the same time I was updating it to finally work for the tides. I agree on the conversion to snake_case.
I should have figured this out sooner but the 'commit to main' on the desktop app does not actually push it all the way to the main branch but instead I must push to origin.... Still working this out and so once I figure out how to accept your branch I will do :)
I need to have a few more conversations to ensure that people still agree with the use of their book (since really it is a total of four books (the trad book is a culmination of 3 with some extras). However I am planning on enabling users to add their own climbs and names when it eventually gets to that point..
I'm afk (off island) for the week but will add this to a main priority once I'm back.
And again - thanks for helping out here
Hi,
I think I've updated my PR by incorporating your recent commits. There are, however, still some conflicts.
.Rhistory
was deleted in mine, you still have it even though it's in your .gitignore..gitignore
I'm not sure why it's not auto merging... anyway, I would recommend accepting my changes on this oneIsland Climbing.R
, R/app_build.R
, R/functions.R
, and R/web_scraping.R
on my PR have all been moved into a folder called scripts_for_processing
as these are not just files with function definitions in and so aren't suited to be in the R/
folder of an R package, see above.I should also add that I complicated things by adding my commits to main
. I should have made a feature branch on my fork and worked on that. Will do next time.
Actually, on second thought, this PR is a mess... I'm going to start again.
I've made a number of changes that set you up for working on this as a package.
data-raw
and reformatted your old data cleaning script to process the data into a data.frame that's shipped with the package. Note that I've taken the liberty to change all the column headers tosnake_case
rather thanTitle Case
. This will make it easier to work with in the long run.data-raw
but haven't written scripts to process them, as it doesn't look like you have used them yetscripts_for_processing
). These weren't in the format required for R packages (only function definitions, nolibrary()
calls, etc). So they are still in the working directory, but outside the package structure. I think we can slowly take bits of these and build them back into the mainR
folder as we go.Still to do