Ryan-Hardiman / Island_Climbing

A code based version of the Guernsey Trad Climbing Guide
0 stars 1 forks source link

Rearrange project to make a package #2

Closed mijon closed 1 year ago

mijon commented 1 year ago

I've made a number of changes that set you up for working on this as a package.

Still to do

Ryan-Hardiman commented 1 year ago

Hey, it looks like you were looking at the code at the same time I was updating it to finally work for the tides. I agree on the conversion to snake_case.

I should have figured this out sooner but the 'commit to main' on the desktop app does not actually push it all the way to the main branch but instead I must push to origin.... Still working this out and so once I figure out how to accept your branch I will do :)

I need to have a few more conversations to ensure that people still agree with the use of their book (since really it is a total of four books (the trad book is a culmination of 3 with some extras). However I am planning on enabling users to add their own climbs and names when it eventually gets to that point..

I'm afk (off island) for the week but will add this to a main priority once I'm back.

And again - thanks for helping out here

mijon commented 1 year ago

Hi,

I think I've updated my PR by incorporating your recent commits. There are, however, still some conflicts.

I should also add that I complicated things by adding my commits to main. I should have made a feature branch on my fork and worked on that. Will do next time.

Actually, on second thought, this PR is a mess... I'm going to start again.