search

Ryan-L98 / pe

0 stars 0 forks source link

Editing networkers.json file wrongly causes all data to be lost #2

Open Ryan-L98 opened 2 years ago

Ryan-L98 commented 2 years ago

Editing the value of an attribute to null in the networkers.json causes all data to be lost.

Steps to reproduce:

  1. Open the program and ensure that there is existing data.
  2. Edit one of the client's name field to null.
  3. Save the file and exit.
  4. Open the program again and there will be no data.

The user guide does not give any warning about this.

nus-se-script commented 2 years ago

Team's Response

Opening the data file manually and intentionally changing the data field can be either deliberate sabotage or due to a bug/mistake; as such, it will be very rare for the users to directly modify the data, so we reduced the severity to Low. Furthermore, we marked this bug as a documentation bug because we should have stated this fact in the User Guide, and also because the terminal log does state that data is corrupted and the app will start empty.

Items for the Tester to Verify

:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: This is a constraint, and therefore cannot be justified that it is rare user behaviour. I still think the severity should be Medium even though I agree that it is a documentation bug. As I would deem this as quite a big flaw if a user can unknowingly lose all their data unintentionally.