search

Ryan-Reno / pe

0 stars 0 forks source link

There are still instances of addressBook in the DG and code base #12

Open Ryan-Reno opened 2 months ago

Ryan-Reno commented 2 months ago

As addressBook was the name of the original app, it doesn't make sense to retain the files to still have instances of addresbook, such as AddressBookParser and AddressBookStorage. Future developers who intend to build on this app will have a lot of confusion as to what these files are, as they are unaware that this application was built on top of AddresBook. Thus, changing these files to fit the name of the current app is very important to do

soc-se-bot commented 2 months ago

Team's Response

Class names that are similar to AddressBook are due to our app still being an adaptation of an Address Book for students and since the app also still functions as AddressBook it is not incorrect for it to have classes related to "AddressBook"

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your explanation]