search

Ryan-rsm-McKenzie / bsa

C++ library for working with the Bethesda archive file format
MIT License
41 stars 6 forks source link

Add "all" archive #1

Closed Guekka closed 3 years ago

Guekka commented 3 years ago

This PR adds another archive class in the all namespace. This class provides a convenient and common interface to all archive types.

codecov[bot] commented 3 years ago

Codecov Report

Merging #1 (a07c244) into master (6e2845d) will decrease coverage by 6.26%. The diff coverage is 7.94%.

:exclamation: Current head a07c244 differs from pull request most recent head 272aaa4. Consider uploading reports for the commit 272aaa4 to get more accurate results Impacted file tree graph

@@            Coverage Diff             @@
##           master       #1      +/-   ##
==========================================
- Coverage   94.51%   88.24%   -6.27%     
==========================================
  Files           9       17       +8     
  Lines        1277     2238     +961     
==========================================
+ Hits         1207     1975     +768     
- Misses         70      263     +193
Impacted Files Coverage Δ
include/bsa/all.hpp 0.00% <0.00%> (ø)
src/bsa/all.cpp 0.00% <0.00%> (ø)
tests/src/bsa/all.test.cpp 0.00% <0.00%> (ø)
examples/pack_unpack.cpp 87.32% <80.95%> (-7.03%) :arrow_down:
tests/src/bsa/tes3.test.cpp 100.00% <0.00%> (ø)
tests/src/bsa/fo4.test.cpp 100.00% <0.00%> (ø)
tests/src/bsa/tes4.test.cpp 99.64% <0.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6e2845d...272aaa4. Read the comment docs.

Ryan-rsm-McKenzie commented 3 years ago

I'm not interested in supporting this class. This kind of thing seems more tailored for your own code base.

Guekka commented 3 years ago

I understand, but:

  1. This class would make this library way more accessible to anyone wishing to use it
  2. It's not a large piece of code, and would likely require very few maintenance

Anyway, that's your choice