search

Ryan-rsm-McKenzie / bsa

C++ library for working with the Bethesda archive file format
MIT License
41 stars 6 forks source link

Remove redeclaration of internal DirectX function #10

Closed Guekka closed 2 years ago

Guekka commented 2 years ago

Latest DirectXTex update made it public, so it's not needed anymore

codecov[bot] commented 2 years ago

Codecov Report

Merging #10 (72e6734) into master (af2f81e) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #10   +/-   ##
=======================================
  Coverage   89.52%   89.52%           
=======================================
  Files          19       19           
  Lines        2625     2625           
=======================================
  Hits         2350     2350           
  Misses        275      275
Impacted Files Coverage Δ
src/bsa/fo4.cpp 90.96% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update af2f81e...72e6734. Read the comment docs.

Guekka commented 2 years ago

It appears the CI does not use the latest vcpkg?

Ryan-rsm-McKenzie commented 2 years ago

It uses the vcpkg bundled with the runner. Check the virtual environment details to see if vcpkg is using the commit you need.

Guekka commented 2 years ago

Vcpkg (build from master <5cf60186a>)

That is 14 days ago. Well, I guess this PR will wait