search

Ryan-rsm-McKenzie / bsa

C++ library for working with the Bethesda archive file format
MIT License
41 stars 6 forks source link

Add vcpkg portfile #2

Closed Guekka closed 3 years ago

Guekka commented 3 years ago

I've also joined example of portfile, but it is not necessary to include in the repo. Would be better in official vcpkg repo

Guekka commented 3 years ago

@Ryan-rsm-McKenzie Do you prefer that? I changed line 14 of the portfile

Guekka commented 3 years ago

Thanks, I appreciate it

Guekka commented 3 years ago

Gonna cleanup the commits

Guekka commented 3 years ago

I think we're good. Do you want me to make a PR at vcpkg repo?

Ryan-rsm-McKenzie commented 3 years ago

lgtm

Guekka commented 3 years ago

Thank you for reviewing this PR, instead of doing it all by yourself. I know it would have been faster for you

Guekka commented 3 years ago

@Ryan-rsm-McKenzie Cleaned up the history, I think you can merge it now

Ryan-rsm-McKenzie commented 3 years ago

This should be added as a pr to vcpkg, it serves no purpose in the main repo

Guekka commented 3 years ago

This should be added as a pr to vcpkg, it serves no purpose in the main repo

Agreed, I wasn't sure what you wanted. Will do