search

Ryan-rsm-McKenzie / bsa

C++ library for working with the Bethesda archive file format
MIT License
41 stars 6 forks source link

Fix #5 #6

Closed Guekka closed 2 years ago

Guekka commented 2 years ago

The new test may need some refactoring, according to your preferences

codecov[bot] commented 2 years ago

Codecov Report

Merging #6 (dc7c142) into master (17e4069) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master       #6   +/-   ##
=======================================
  Coverage   89.47%   89.47%           
=======================================
  Files          19       19           
  Lines        2595     2595           
=======================================
  Hits         2322     2322           
  Misses        273      273
Impacted Files Coverage Δ
src/bsa/fo4.cpp 90.85% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f09e9c4...dc7c142. Read the comment docs.

Ryan-rsm-McKenzie commented 2 years ago

What's the licensing on this dds file?

Guekka commented 2 years ago

No files that are packaged as part of Falskaar may be redistributed in any way shape or form. This includes the ESM, Bink video files, and any files contained within the BSA. The one and only exception to this are the Script and source (PSC and PEX) files. These may be altered and redistributed freely.

I suppose I need to find another file

Guekka commented 2 years ago

Done

Guekka commented 2 years ago

Is it okay like that?