search

Ryan-rsm-McKenzie / bsa

C++ library for working with the Bethesda archive file format
MIT License
41 stars 6 forks source link

Fix cubemap extraction out of ba2 #9

Closed Guekka closed 2 years ago

Guekka commented 2 years ago

For some reason, DX10 header break some cubemaps Before you ask, yes, these files are copyright free. They're from here https://www.nexusmods.com/skyrim/mods/95466?

codecov[bot] commented 2 years ago

Codecov Report

Merging #9 (513ea4f) into master (acf0942) will increase coverage by 0.08%. The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #9      +/-   ##
==========================================
+ Coverage   89.48%   89.57%   +0.08%     
==========================================
  Files          19       19              
  Lines        2616     2619       +3     
==========================================
+ Hits         2341     2346       +5     
+ Misses        275      273       -2
Impacted Files Coverage Δ
src/bsa/fo4.cpp 91.24% <80.00%> (+0.44%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update acf0942...513ea4f. Read the comment docs.

Ryan-rsm-McKenzie commented 2 years ago

Can you add a license.txt to the archive to indicate the source of the textures?