RyanBluth / Bandcamp-Greasy

Download Your Bandcamp Collection
MIT License
255 stars 43 forks source link

Getting Error 429 Too Many Requests #17

Closed alexjapp closed 3 years ago

alexjapp commented 4 years ago

Is there a way to use rate limiting to avoid this error?

RyanBluth commented 4 years ago

How many albums were you trying to download?

alexjapp commented 4 years ago

77

RyanBluth commented 4 years ago

I might be able to add something to solve this; probably some sort of delay after opening each album. In the meantime, I'd suggest using the download range option to download 20 or so at a time. If you take a little break between each set it should solve the problem hopefully.

alexjapp commented 4 years ago

Cool, thanks.

Fewshin commented 4 years ago

I actually fixed this last night. I'll make a PR

Edit: #18

dromer commented 3 years ago

I ran into this trying to download 11 albums from my account. In FLAC.

The first 4 went through fine, but after that all tabs got this error.

duntwave commented 3 years ago

same thing happening to me with FLACs. wish for any type of fix honestly I just like having downloads going while I'm asleep. works fine with mp3s typically.

duntwave commented 3 years ago

I think maybe an album queue timer or delay or whatever would help instead of just opening everything at the same time

RyanBluth commented 3 years ago

I'll try to take a look at this soon. I think adding a delay between downloads is the only solution that'll work probably

RyanBluth commented 3 years ago

I've added an option to throttle downloads. There are global variables at the top of the script that you can change or you can enable it through the UI

duntwave commented 3 years ago

everything seems to be working much more smoothly now! thanks a million. I'll put this on while I sleep and report back

duntwave commented 3 years ago

btw there should be an option to make it sequential where it'll only trigger the next download after one or however many you choose have completed. not sure how you'd do that but just a thought

RyanBluth commented 3 years ago

I don't think that's possible since the download process is controlled by the browser. I am also pretty sure that the frequency of requests is measured by the start of each request, not the completion