search

RyanEdwardHall / anagrambler

Finds all anagrams and sub-anagrams in a string
MIT License
4 stars 1 forks source link

Switch from TravisCI to GitHub Actions and add linting #21

Closed mcgid closed 2 years ago

mcgid commented 3 years ago

I don't think Travis is accepting our builds anymore, and GHA is more integrated with the github UI, so I'm just going to switch it over to GHA.

GHA includes 2000 minutes per month so we should be fine with running the workflow on: push.

The 'Set up Go' step is needed in both jobs, which I find a little confusing: I was expecting the linter to be just a binary, and thus not need Go installed. But without it the linter fails.

I think I'm going to merge this even with the tests failing: the next thing I want to do is fix the tests in a nontrivial way, so I don't think it's worth trying to cram that in here.

mcgid commented 2 years ago

I decided to remove the tests instead of merging with failing ones. They weren't useful tests anyway; the results were unverified, and the code isn't structured right for them to be unit tests anyway. I'm gonna go ahead and yolo this now.