search

RyanGlScott / mintty

A reliable way to detect the presence of a MinTTY console on Windows
BSD 3-Clause "New" or "Revised" License
4 stars 1 forks source link

Why does mintty depend on filepath? #5

Closed Bodigrim closed 2 years ago

Bodigrim commented 2 years ago

https://github.com/RyanGlScott/mintty/blob/28fe58c9927ceff2d636a14b780642092d734bf3/mintty.cabal#L69-L70 However I do not see System.FilePath to be imported.

RyanGlScott commented 2 years ago

A good question. mintty used to import System.FilePath, but that import was removed in e03176ee725bcc56e28e6622a81cc020d8474d15. It looks like I forgot to remove the filepath dependency at the same time.

Bodigrim commented 2 years ago

There is an ongoing work on filepath-2.0, and it would help to reduce the amount of packages to rebuild when running tests / benchmarks.

RyanGlScott commented 2 years ago

I've submitted #6 with a fix.