RyanGreenup / cadmus

Shell Scripts to Facilitate Effective Note Taking
168 stars 7 forks source link

shorter alternatives and a little refactor #6

Closed danimateo closed 4 years ago

RyanGreenup commented 4 years ago

Sorry for the late reply, I thought GitHub would notify me of PR's, I didn't realise I had to watch my own repo :rofl:.

Do you think we should have shorter commands or do you think we should just leave it to the user to implement aliases?

Oh I see the | is or, I overlooked that, unfourtunately the branches have diverged so I'll have to go through and do that now.

I'm happy either way, but that's why I left the names long and descriptive, e.g.:

alias np='cadmus  preview'
RyanGreenup commented 4 years ago

How should we implement the help :thinking:, maybe bold only the first matching letter?

    echo -e " 🔍 \e[1;93m \e[1mf\e[0m\e[93mind \e[0m \e[1;34m    ┊┊┊ 🎆 \e[0m Find Notes based on FileName"

image

danimateo commented 4 years ago

Yeah, that looks great!

RyanGreenup commented 4 years ago

Alright thanks heaps, I'll merge in those changes and I'll make an issue on emboldening the shortcut keys in case I forget to do that