RyanLamansky / dotnet-webassembly

Create, read, modify, write and execute WebAssembly (WASM) files from .NET-based applications.
Apache License 2.0
789 stars 74 forks source link

(WIP) Handle unreachable #29

Closed tana closed 3 years ago

tana commented 3 years ago

This PR allows compilation of some WASM codes which previously generated compilation error. In particular, it solves some unreachable-related problems, such as:

What I did was:

However, at present, some invalid WASM code involving unreachable (in SpecTest_unreached_invalid) passes compilation, because all unreachable code is now ignored. Therefore, this PR is currently marked Draft.

(Update)

tana commented 3 years ago

I will try to fix the SpecTest_unreached_invalid problem, but because my lack of time, I am not sure when it will complete.

tana commented 3 years ago

I apologize for wasting CPU time of your GitHub Actions CI server. I will refrain from pushing commits until large progress is achieved.

RyanLamansky commented 3 years ago

This project leverages GitHub's hosted actions provider, which is free and effectively unlimited for open source projects like this. Nothing to worry about 🙂

If you want to reduce noise, you could close the PR while you continue to refine your solution and then open a new one.

tana commented 3 years ago

Thank you.

I think PR became a bit dirty (such as wrong commit message). So I decided to close this and make a new one later.