Closed tana closed 3 years ago
I will try to fix the SpecTest_unreached_invalid
problem, but because my lack of time, I am not sure when it will complete.
I apologize for wasting CPU time of your GitHub Actions CI server. I will refrain from pushing commits until large progress is achieved.
This project leverages GitHub's hosted actions provider, which is free and effectively unlimited for open source projects like this. Nothing to worry about 🙂
If you want to reduce noise, you could close the PR while you continue to refine your solution and then open a new one.
Thank you.
I think PR became a bit dirty (such as wrong commit message). So I decided to close this and make a new one later.
This PR allows compilation of some WASM codes which previously generated compilation error. In particular, it solves some
unreachable
-related problems, such as:wasm.zip
successfully compiles, aside from lacking imports)SpecTest_unreachable
(removed[Ignore(StackSizeIncorrectException)]
and passes this spec test).What I did was:
StackSizeException
inSpecTest_unreachable
.BlockContext
mechanism insideCompilationContext
, to remember stack at the beginning of a block and whether the compiling instruction is reachable.However, at present, some invalid WASM code involving
unreachable
(inSpecTest_unreached_invalid
) passes compilation, because all unreachable code is now ignored. Therefore, this PR is currently marked Draft.(Update)
return
,br
,br_table
. (Sorry, commit message of 62d5fd8 is mistake)