RyanLua / Satchel

A modern alternative to Roblox's default backpack. Satchel aims to be more customizable and easier to use than the default backpack while still having a "vanilla" feel.
http://satchel.ryanluu.dev
Mozilla Public License 2.0
35 stars 4 forks source link

Numerous tooltip-related issues with in-experience translation #1

Closed RyanLua closed 1 year ago

RyanLua commented 1 year ago

Contact Details

https://devforum.roblox.com/u/winnerstakesall

What happened?

They are many issues with in-experience translation and tooltips. This is probably due to how some translation scripts are not made for RobloxGui and CoreGui only.

Excerpt from GameTranslator.lua

-- This is meant for translating user game text that appears under CoreGui.
-- It uses Player.LocaleId and the LocalizationTables under LocalizationService.
-- This includes team names, score names, tool names, and notification toasts.
-- DO NOT USE THIS TO TRANSLATE ROBLOX TEXT IN ROBLOX GUIS!!!
-- Text from Roblox in Roblox guis should use LocalizationService.RobloxLocaleId
-- and the CoreScriptLocalization table, NOT user tables with the game locale ID.

Steps to reproduce

1. Open settings in an experience with translations enabled.
2. Change experience language to any other language.

Relevant log output

No response

Other details

No response

Code of Conduct

RyanLua commented 1 year ago

It seems I would need to rewrite how translations are handled entirely for Satchel.

RyanLua commented 1 year ago
  • Some tooltips will not correctly size with translations image

Sizing for tooltip names has been fixed with https://github.com/RyanLua/Satchel/commit/ee38b90c93a07228f5a81727c050948e03f69a45.

image

RyanLua commented 1 year ago

Some tooltips are not translated at all. image

This seems to no longer be broken for some reason. It could be that the experience I was testing on wasn't fully translated?