RyanMillerC / poke-line

Minor Emacs mode to show buffer position using a Pokémon!
GNU General Public License v3.0
34 stars 2 forks source link

Misc improvements, allow per-buffer settings #12

Closed purcell closed 4 years ago

purcell commented 4 years ago

Hey! Thanks for this fun package. I'm finding it a nice alternative to nyan-mode.

The one thing I immediately wanted to be able to do was randomise the Pokemon in each buffer, but that wasn't possible given the original code (which relied on a global minor mode) so I did a bunch of refactoring to make it possible. Along the way I've simplified a lot of the original code.

There's a minor breaking change, in that poke-line-mode is now a local minor mode, while a separate poke-line-global-mode does what the old poke-line-mode did. I've updated the docs accordingly.

purcell commented 4 years ago

Note that to actually set a random pokemon in each buffer, someone (me!) should now be able to do this:

(make-variable-buffer-local 'poke-line-pokemon)
(add-hook 'poke-line-mode-hook 'poke-line-set-random-pokemon)
RyanMillerC commented 4 years ago

Thanks for this PR! I think these are good changes. A lot of the structure of this package came from nyan-mode and the rest I improvised. I'm sure there is room for even more improvement. 😅

I am getting an error though when I load poke-line.el from your branch: Symbol's function definition is void: poke-line-refresh.

purcell commented 4 years ago

I am getting an error though when I load poke-line.el from your branch: Symbol's function definition is void: poke-line-refresh.

My bad, it needed to be defined before being referenced in the defcustoms, since the initial execution of the defcustom form calls its :set form. Fixed now, in any case.

purcell commented 4 years ago

Will just take a look at those conflicts.

purcell commented 4 years ago

Cool, that should do it.

RyanMillerC commented 4 years ago

Cool, thanks!

purcell commented 4 years ago

Yay!