Closed purcell closed 4 years ago
Note that to actually set a random pokemon in each buffer, someone (me!) should now be able to do this:
(make-variable-buffer-local 'poke-line-pokemon)
(add-hook 'poke-line-mode-hook 'poke-line-set-random-pokemon)
Thanks for this PR! I think these are good changes. A lot of the structure of this package came from nyan-mode and the rest I improvised. I'm sure there is room for even more improvement. 😅
I am getting an error though when I load poke-line.el from your branch: Symbol's function definition is void: poke-line-refresh
.
I am getting an error though when I load poke-line.el from your branch:
Symbol's function definition is void: poke-line-refresh
.
My bad, it needed to be defined before being referenced in the defcustoms
, since the initial execution of the defcustom
form calls its :set
form. Fixed now, in any case.
Will just take a look at those conflicts.
Cool, that should do it.
Cool, thanks!
Yay!
Hey! Thanks for this fun package. I'm finding it a nice alternative to nyan-mode.
The one thing I immediately wanted to be able to do was randomise the Pokemon in each buffer, but that wasn't possible given the original code (which relied on a global minor mode) so I did a bunch of refactoring to make it possible. Along the way I've simplified a lot of the original code.
There's a minor breaking change, in that
poke-line-mode
is now a local minor mode, while a separatepoke-line-global-mode
does what the oldpoke-line-mode
did. I've updated the docs accordingly.