RyanMillerC / poke-line

Minor Emacs mode to show buffer position using a Pokémon!
GNU General Public License v3.0
34 stars 2 forks source link

feature: poke-line-capture-predicate #13

Closed progfolio closed 3 years ago

progfolio commented 4 years ago

Allow custom function to display a pokeball in the modeline. This is the most general and flexible way I think this could be implemented. Some examples for showing a pokeball:

(setq poke-line-capture-predicate (lambda () (= (line-number-at-pos) 1)))
(setq poke-line-capture-predicate (lambda () (or (bobp) (eobp)))
(setq poke-line-capture-predicate (lambda () (string= (buffer-name) "*scratch*")))

See: #4

RyanMillerC commented 4 years ago

This seems like it could work. I think it would look weird if the Pokéball was active in any buffer position other than the top because of the element type effect. The position bar would hang in front of the Pokéball and wouldn't be visually connected.

Will this PR be able to work with the changes being introduced in #12?

progfolio commented 4 years ago

https://github.com/RyanMillerC/poke-line/issues/3#issuecomment-678906064

I believe we could simplify by treating the pokeball as a pseudo pokemon if linked comment is implemented.

RyanMillerC commented 4 years ago

PR #12 referenced in that issue has been merged. Can you update this PR to reflect the pseudo Pokémon idea?