search

RyanMullins / angular-hammer

Hammer.js v2 support for AngularJS
http://ryanmullins.github.io/angular-hammer/
MIT License
188 stars 55 forks source link

Event no longer passing after updating to 2.1.3, 2.1.4 #21

Closed skawaguchi closed 9 years ago

skawaguchi commented 9 years ago

I'm using angular-hammer like this:

    <a ng-repeat="someItem in someList" hm-tap="myFunction( $event, someItem )">My Link</a>

The directive used to pass $event, but it no longer does in 2.1.3 or 2.1.4.

I know that the usage doesn't really follow your examples. I wasn't sure how else to get the object in my repeated into the tap function.

skawaguchi commented 9 years ago

This pen shows the issue.

RyanMullins commented 9 years ago

I think I fixed this today with v2.1.5. Take a look using that and let me know.

skawaguchi commented 9 years ago

I updated the pen with 2.1.5 and the event still isn't being passed.

equilerex commented 9 years ago

Same here... cant pass $event on v2.1.9

RyanMullins commented 9 years ago

So the reason you weren't getting the $event is because i wasn't defining a locals object and passing it to the handler expression function returned by $parse. Please reopen if you find the fix isn't working.