RyanNgWH / pe

0 stars 0 forks source link

Error message for DOB does not specify the exact issue. #5

Open RyanNgWH opened 2 months ago

RyanNgWH commented 2 months ago

image.png

The issue here is that the date does not exist (i.e There is no 29 Feb in 2022). However, based on the error message, it might seem that there is no issue since it is in the correct specified format and is within the acceptable date range

nus-pe-bot commented 2 months ago

Team's Response

Thank you for pointing out this issue. We think that while an optimal system would definitely do this, our current error message does at least highlight to the user that there is an issue with the date, which can allow a user to then figure out the problem and correct it. To implement a special check for Feb-29 would be extra implementation effort that we did not find as important (because it would be beneficial in only extremely rare situation - and the current error message is fairly specific already) as some of the other features, given that we were working under time and manpower constraints. However, this is definitely something we can look into down the line, hence the 'NotInScope'.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: [replace this with your explanation]