RyanNgWH / pe

0 stars 0 forks source link

Unnecessary seperate commands for `adddoctor` and `addpatient` #7

Open RyanNgWH opened 2 months ago

RyanNgWH commented 2 months ago

Both commands seem to be accomplishing the exact same thing (same fields with the same restrictions), apart from tagging the person as either a doctor or a patient. It might be simpler to combine both commands into an add command and simply specify a new parameter to tag the person differently.

nus-se-bot commented 2 months ago

Team's Response

Thank you for raising this. The command structure is something our group has put careful thought into. After some further discussion, we stand by our stance that two separate commands seems more appropriate for our product scope. In a real hospital setting, there will be far more patients being admitted and administered than there are new doctors hired or old doctors transferring / retiring. Thus, using one single command necessitates the hospital clerks to type out the same repetitive type = patient parameter many times. With our current implementation, they can just use the ready built addpatient command, which has one less parameter, translating to faster entry and less changes for typos or errors.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your explanation]