search

RyanRussell00 / personal-dj

Personal DJ site that creates playlists given custom inputs. View it live at: http://personaldj.net/
http://personaldj.net/
MIT License
26 stars 12 forks source link

Add loading gif when loading recommendations or creating playlist #1

Closed RyanRussell00 closed 3 years ago

RyanRussell00 commented 3 years ago

When the user clicks on "Get Recommendations" there should be something (such as a gif) that lets the user know that it's loading and whether it was a success or failure.

RyanRussell00 commented 3 years ago

I've changed the text of the buttons to "loading" when they're loading but I'd like an actual gif or something that ends with success or failure.

astriskit commented 3 years ago

let me send PR for this!

astriskit commented 3 years ago

@RyanRussell00 - I'm unable to test my changes due to limitations of .env; Any ideas on how to proceed?

Anyways I'm going to open a PR and then you let me know the results - so as to change it further;

I'd suggest, though, for making it a faster feedback loop - try using sort of build pipeline;

Update: I'll defer doing anything, until you respond.

RyanRussell00 commented 3 years ago

@astriskit In the GETTING_STARTED I outline the steps for setting up the necessary .env variables to run it locally.

The reasons I haven't setup a build pipeline yet is: 1) I need to write tests 2) The secrets are not visible to anyone who forks the repo, which means they need to setup their own secrets.

I've made an issue for myself on GitHub to create a build pipeline and set up all this stuff. Thanks for your input!

Let me know if you still want to take on this issue.

astriskit commented 3 years ago

Ok - @RyanRussell00 - will take this up.

RyanRussell00 commented 3 years ago

@astriskit Fantastic, thank you! I've also added the Hacktoberfest label to this issue.