search

RyanRussell00 / personal-dj

Personal DJ site that creates playlists given custom inputs. View it live at: http://personaldj.net/
http://personaldj.net/
MIT License
25 stars 12 forks source link

add a favicon to the head of the website #3

Closed thesmartdeveloperr closed 4 years ago

thesmartdeveloperr commented 4 years ago

It would be pretty nice to include a nice favicon along with the title for more familiarity, as now the webpage renders default favicon(that earth like one). @RyanRussell00 what do you think?

RyanRussell00 commented 4 years ago

@thesmartdeveloperr Sounds good! If you have any good favicon ideas (copyright free pls) please link them!

RyanRussell00 commented 4 years ago

If anyone takes this issue please provide a URL to the original favicon image just so I can check for copyright rules

nidhishs commented 4 years ago

Hey. I can design a custom favicon for you guys if you want. I have some experience with graphic designing.

RyanRussell00 commented 4 years ago

@nidhishs Sounds good! Thank you!

nidhishs commented 4 years ago

@RyanRussell00 I just designed this real quick as a v1.0

I used the colours I found on your website. Let me know of any issues or any changes you want. PdJ

Also, if you don't mind, could you please add the Hacktoberfest label to this issue so it contributes towards my PRs?

RyanRussell00 commented 4 years ago

@nidhishs I really like it! My only suggestion is to remove the white cable thingy, I think it looks cleaner without it. Let me know what you think, and if it's ready to go please submit a PR. I also added the Hacktoberfest label.

nidhishs commented 4 years ago

@nidhishs I really like it! My only suggestion is to remove the white cable thingy, I think it looks cleaner without it. Let me know what you think, and if it's ready to go please submit a PR. I also added the Hacktoberfest label.

Sure. The white pointer does seem a bit out of place. I'll add a PR. Please let me know in which format and where I should add the file.

Update: @RyanRussell00 I have added a PR to address this issue. Check it out.