search

RyanRussell00 / personal-dj

Personal DJ site that creates playlists given custom inputs. View it live at: http://personaldj.net/
http://personaldj.net/
MIT License
25 stars 12 forks source link

Added more customized inputs for recommendations #33

Closed sonamdh1 closed 4 years ago

sonamdh1 commented 4 years ago

Added optional inputs such as:

Added validation and hint-text for the fields.

RyanRussell00 commented 4 years ago

@sonamdh1 This looks good! The only thing missing is sending the extra parameters to the Spotify API in the app.js but I can handle that in another branch since I know that testing it can get difficult. I'll merge this into master as soon as I get the chance to handle the merge conflicts and add the app.js stuff.

Thanks!

sonamdh1 commented 4 years ago

@RyanRussell00 Great! Actually I can add that part, can add it to this PR itself.

RyanRussell00 commented 4 years ago

@sonamdh1 That would be great if you could! I tried doing it last night but for some reason your code isn't working on my machine, the index.html isn't displaying the #step-2 div. I think it could have been due to the merge conflicts as well.

If you could handle the merge conflicts and update the apo.js that would be awesome, thanks! Let me know if you need help

sonamdh1 commented 4 years ago

@RyanRussell00 I have integrated the additional API params in api.js. I have verified the working and the URL getting constructed. Will try to resolve the merge conflicts as well.

sonamdh1 commented 4 years ago

@RyanRussell00 I have resolved the merge conflicts. I have verified the functionality of the PR. Can you please verify if the rest of the functionality is working fine as well like "Filter explicit content"? Let me know if any change is required.

RyanRussell00 commented 4 years ago

@sonamdh1 This is fantastic! Thank you for this!