search

RyanRussell00 / personal-dj

Personal DJ site that creates playlists given custom inputs. View it live at: http://personaldj.net/
http://personaldj.net/
MIT License
25 stars 12 forks source link

added checker for creating duplicate playlist #36

Closed utkarsh4321 closed 4 years ago

utkarsh4321 commented 4 years ago

Hii @RyanRussell00 thanks for this great opportunity. I worked on issue #7. And added some fixes on the basis of your requirement. Can you please review my PR? And let me know if there is any problem so I will try to fix it asap.

utkarsh4321 commented 4 years ago

Hii @RyanRussell00 I wanna ask one thing why you use explicit button event handler into two places. Can you explain to me about it? image The first one inside playlist-button event handler and the second one below this handler you can see into above screenshot

utkarsh4321 commented 4 years ago

One thing more if anyone clicked on recommendation then need to reset flag for both explicit playlist and non-explicit playlist

RyanRussell00 commented 4 years ago

@utkarsh4321

  1. The explicit function inside the playlist button was leftover from the merge conflict. Thanks for catching that! I've removed it and updated master.

  2. Whenever new recommendations are generated it should reset both flags: explicit and non-explicit. This is because when they click on "get recommendations", an entirely new playlist is curated for them.

Let me know if you have any more questions

utkarsh4321 commented 4 years ago

Hii @RyanRussell00 I fix the explicit playlist confirmation problem can you please review my PR. If there is any problem then tell me. I will try to fix asap.

utkarsh4321 commented 4 years ago

Hii @RyanRussell00 is there any problem with it can you please tell me so I will fix it.