search

RyanRussell00 / personal-dj

Personal DJ site that creates playlists given custom inputs. View it live at: http://personaldj.net/
http://personaldj.net/
MIT License
26 stars 12 forks source link

Make all inputs optional #37

Closed RyanRussell00 closed 3 years ago

RyanRussell00 commented 3 years ago

Convert all the inputs (except for seeded track) to optional, allowing people to leave fields such as "popularity", "danceability", etc. blank if they wish to. The seeded track is a mandatory field. Follow API documentation for Recommendations API to see what's allowed to be optional. https://developer.spotify.com/documentation/web-api/reference/browse/get-recommendations/

maw1a commented 3 years ago

I would like to work on this.

RyanRussell00 commented 3 years ago

@maw1a All yours. Please open a PR and assign me as a reviewer when it's ready!

We already have some optional inputs on the app, you can just follow that same style for the rest of the inputs. Please look at the API documentation to see what inputs are allowed to be optional and which aren't.

Please note that if an optional input is filled out, but is invalid, the UI should still show an error beside the field, but it can still go ahead and generate the recommendations. You can see what I mean if you go to the site, search for a track, enter valid required inputs, open the optional inputs, and enter an invalid optional input. It will show you an error beside the form saying that the input is invalid, but it will still generate the playlist.

Let me know if you have any questions!

RyanRussell00 commented 3 years ago

This issue is open for anyone to work on