[RESOLVED]Location of saved pin is bad

Ryasnoy / AppLocker

AppLocker - simple lock screen for iOS Application ( Swift 4+, iOS 9.0+) Touch ID / Face ID

MIT License

211 stars 46 forks source link

[RESOLVED]Location of saved pin is bad #8

Closed MasterOP22 closed 5 years ago

MasterOP22 commented 6 years ago

Hey,

i checked the detail Code of the AppLocker Implementation and i was not amused to see that you save the pin in the UserDefaults by default. Its really unsecure to use that place and it seems that there is no chance to change the location? Im right? Is it possible to give the user the control over the save location of the pin code?

Ryasnoy commented 6 years ago

Hello. Thank you for your feedback. Im going to add the control for developers such as Keychain, UserDefaults, Custom.

pouriaalmassi commented 5 years ago

@MasterOP22 and @Ryasnoy I just put up a PR #9 to attempt to address this issue.

Ryasnoy commented 5 years ago

@pouriaalmassi thank you. Your solution now available in 'Release 2.0' Added 'Valet' to pods dependencies.