search

Rybadour / Foreman

Visual planning tool for the game Factorio
Other
21 stars 7 forks source link

[BitBucket Copy] Item icons are displayed incorrectly. #15

Open Rybadour opened 4 years ago

Rybadour commented 4 years ago

Using Factorio 0.18.4

See attached screenshot for demonstration of issue.

2020-02-11_13-40-55

Chakani42 commented 4 years ago

The icon Size for all of these icons seems to be hard coded in Foreman at 32x32. I've found that in .18, these icons look to have primarily been shifted to 64x64, with the Lua specifying that as the icon_size. I've found that upon rolling back to Factorio 0.17.79, the issue is gone for most items, but still present for the ore items, which are the only things I've found thus far in .17 that have 64x64 icon_sizes. I'm not entirely sure how to fix this globally while allowing for compatibility with older versions yet (and I assume the bitmaps will need to be resized to fit in their designated boxes?), but working on that now! My assumption is that we need to read the icon_size from the lua for the relevant items, generate the icon from there, and then resize it to what it should be before it's drawn, if any of that is wrong though please let me know!

Kamikaetzchen commented 4 years ago

those are images for mipmapping, should be fixed with #42