search

Rychard / CityWebServer

Integrated Web Server for Cities: Skylines
58 stars 21 forks source link

Learning in fork #1

Open Feanathiel opened 9 years ago

Feanathiel commented 9 years ago

Hey there,

I noticed your project earlier today on the Steam Workshop, which I found it quite interesting. The workshop linked to the current GitHub project. I'm trying to learn a thing or two, making commits in the fork. If you find something interesting and feel like pulling in some commits, feel free to do so. As for now there are not a lot of commits just yet, but I think that will change over time.

I hope you have a nice day, Fe.

Rychard commented 9 years ago

I thoroughly appreciate you taking the time to publish your changes, and letting me know about them. I looked through them all in great detail and I couldn't find any issues with them! The abstraction of the request handlers into the IResponse interface was particularly insightful, and I'm actually quite ashamed that I hadn't thought of it myself.

I merged your branch into a separate branch in the repository and made some minor adjustments before subsequently merging it back into the master branch.

I made sure to merge your changes in to ensure that your commits retain the proper attribution.

Feanathiel commented 9 years ago

Thank you for merging the commits back to your repository. The response interface-idea is derived from ASP.NET MVC, which I found work quite nicely. But I have to say I wouldn't come up with this myself to be honest. I'd like to do something equivalent with the request, but I haven't thought that through yet. This gives you the ability to switch implementation (other than HttpListener) without deriving mods breaking. It's easier to add than to remove.

Earlier I didn't notice I was deviating from the coding standards, thank you for pointing that out.