RychardHunt / Fyt

Personal Workout Application
2 stars 5 forks source link

Sp2 nav bar alex #18

Closed astewartgit closed 5 years ago

astewartgit commented 5 years ago

name: 🚀 NavBar Pull Request about: NavBar


Pull Request

Related Issue Need a bottom navigation bar to navigate between screens. Must be implemented in the native base design language.

Describe the solution you implemented Rewrote the NavBar in native base, and added navigator from the react-navigation library using the native base visual style. Updated package.json's dependencies accordingly. Wrote dummy screens in components/SampleScreens. Removed old BottomBar since it is no longer needed.

Describe alternatives you've considered Now that we're on native base I believe this code is our permanent best solution for the NavBar. The alternative in the future will be fully integrating other screens with the navigational elements.

How Has This Been Tested? Practical testing: clicking through buttons, screenshotting. Implementation is still simple, should be okay. Should implement jest testing in the future.

Screenshots Include screenshots of the feature working.

Types of Changes