Closed Roger-luo closed 2 years ago
Merging #14 (95cf719) into main (6a62b62) will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## main #14 +/- ##
=======================================
Coverage 88.00% 88.00%
=======================================
Files 3 3
Lines 250 250
=======================================
Hits 220 220
Misses 30 30
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 6a62b62...95cf719. Read the comment docs.
A tried this AD engine a bit. I think the design is good in general. So I will merge it directly. But I do not understand why do we need TrackedArray, TrackedArrayTypes, TrackedRealArray, TrackedComplexArray? Isn't TrackedArray alone enough?
not sure all the rules we need are forwarded, need to check with the PEPS example and forward whatever is missing