Open benschiff opened 2 years ago
Nice, this looks very nice. You are really quick in learning a new tool and I am very sure you will become a very good Julia programmer! I will take a look. 👍🏾
I pushed a commit to your branch, normally we do not do this (since it may cause conflicts).
But I want to merge the main branch first and resolve conflicts with git merge main
and remove pyc
files so that I can review easier.
@maddiecain I would suggest you to review this PR (suggestion and questions are all welcomed in a PR review), it is really a good first example for learning tensor networks!
Merging #20 (14186a9) into main (da18273) will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## main #20 +/- ##
=======================================
Coverage 87.25% 87.25%
=======================================
Files 4 4
Lines 259 259
=======================================
Hits 226 226
Misses 33 33
:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more
@GiggleLiu Maybe you could have a look 👀 at the pytorch implementation. Most likely the results are wrong at the moment, I am happy for any comment. I will have to compare with ED at some point.
Hi you can have a look in the bin folder :)